#141680: "incorrect score display"
What is this report about?
What happened? Please select from below
What happened? Please select from below
Please check if there is already a report on the same subject
If yes, please VOTE for this report. Reports with the most votes are given PRIORITY!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detailed description
-
• Please copy/paste the error message you see on your screen, if applicable.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Please explain what you wanted to do, what you did and what happened
• Which browser are you using?
opera
-
• Please copy/paste the text displayed in English instead of your language. If you have a screenshot of this bug (good practice), you can use Imgur.com to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Is this text available in the translation system? If yes, has it been translated for more than 24 hours?
• Which browser are you using?
opera
-
• Please explain your suggestion precisely and concisely so that it's as easy as possible to understand what you mean.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Which browser are you using?
opera
-
• What was displayed on the screen when you were blocked (Blank screen? Part of the game interface? Error message?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Which browser are you using?
opera
-
• Which part of the rules was not followed by the BGA adaptation?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Is the rules violation visible on game replay? If yes, at which move number?
• Which browser are you using?
opera
-
• What was the game action you wanted to do?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• What did you try to do to trigger this game action?
-
• What happened when you tried to do this (error message, game status bar message, ...)?
• Which browser are you using?
opera
-
• At which step of the game did the problem occur? What was the current game instruction?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• What happened when you tried to do this game action (error message, game status bar message, ...)?
• Which browser are you using?
opera
-
• Please describe the display issue. If you have a screenshot of this bug (good practice), you can use Imgur.com to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Which browser are you using?
opera
-
• Please copy/paste the text displayed in English instead of your language. If you have a screenshot of this bug (good practice), you can use Imgur.com to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Is this text available in the translation system? If yes, has it been translated for more than 24 hours?
• Which browser are you using?
opera
-
• Please explain your suggestion precisely and concisely so that it's as easy as possible to understand what you mean.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Which browser are you using?
opera
Report history
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Add to this report
- Another table ID / move ID
- Did F5 solve the problem?
- Did the problem appear several times? Every time? Randomly?
- If you have a screenshot of this bug (good practice), you can use Imgur.com to upload it and copy/paste the link here.
